refactor: move baseUrl fallback logic to paths-plugin.ts#32677
Merged
alan-agius4 merged 3 commits intoangular:mainfrom Mar 4, 2026
Merged
refactor: move baseUrl fallback logic to paths-plugin.ts#32677alan-agius4 merged 3 commits intoangular:mainfrom
baseUrl fallback logic to paths-plugin.ts#32677alan-agius4 merged 3 commits intoangular:mainfrom
Conversation
This ensure that we do not set `baseUrl` internally which would trigger a deprecation warning.
alan-agius4
added
action: review
crisbeto
approved these changes
Mar 4, 2026
alan-agius4
removed
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the fallback logic for baseUrl by moving it from AngularWebpackPlugin to TypeScriptPathsPlugin. This is a good change as it centralizes the path-related logic and avoids modifying the compilerOptions object directly, which helps prevent a deprecation warning. My review includes a minor suggestion to improve the type assertion in paths-plugin.ts for better type safety and code clarity.
alan-agius4
force-pushed
the
webpack-base-url
branch
from
e8431e6 to
395840c
Compare
alan-agius4
force-pushed
the
webpack-base-url
branch
from
395840c to
a377f34
Compare
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensure that we do not set
baseUrlinternally which would trigger a deprecation warning.